Skip to content

Conversation

@Poupine
Copy link
Contributor

@Poupine Poupine commented Oct 17, 2025

Description

Fixed bug where a return statement was missing in src/render/python/shape_v.cpp. Also added a test to cover the function.

Testing

Added a simple unit test to ensure that a single ray traced towards a single triangle intersects it as expected.

Checklist

  • My code follows the style guidelines of this project
  • My changes generate no new warnings
  • My code also compiles for cuda_* and llvm_* variants. If you can't test this, please leave below
  • I have commented my code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I cleaned the commit history and removed any "Merge" commits
  • I give permission that the Mitsuba 3 project may redistribute my contributions under the terms of its license

Copy link
Member

@njroussel njroussel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you 👍

@njroussel njroussel merged commit 377f146 into mitsuba-renderer:master Oct 27, 2025
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants